Re: [PATCH nf-next 3/3] ipvs: add conn_lfactor and svc

lvs-devel

Re: [PATCH nf-next 3/3] ipvs: add conn_lfactor and svc_lfactor sysctl va

To:	Julian Anastasov <ja@xxxxxx>
Subject:	Re: [PATCH nf-next 3/3] ipvs: add conn_lfactor and svc_lfactor sysctl vars
Cc:	Simon Horman <horms@xxxxxxxxxxxx>, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, lvs-devel@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, Dust Li <dust.li@xxxxxxxxxxxxxxxxx>, Jiejian Wu <jiejian@xxxxxxxxxxxxxxxxx>
From:	Florian Westphal <fw@xxxxxxxxx>
Date:	Tue, 24 Mar 2026 14:02:03 +0100

Julian Anastasov <ja@xxxxxx> wrote:
> +                     *valp = val;
> +                     if (rcu_dereference_protected(ipvs->conn_tab, 1))
> +                             mod_delayed_work(system_unbound_wq,
> +                                              &ipvs->conn_resize_work, 0);

Can I change this to rcu_access_pointer()?

rcu_dereference_protected( ... , 1)

... always looks like a bug to me, even though its fine here.

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH nf-next 0/3] IPVS changes, part 4 of 4 - extras, Julian Anastasov [PATCH nf-next 2/3] ipvs: add ip_vs_status info, Julian Anastasov [PATCH nf-next 1/3] ipvs: show the current conn_tab size to users, Julian Anastasov [PATCH nf-next 3/3] ipvs: add conn_lfactor and svc_lfactor sysctl vars, Julian Anastasov Re: [PATCH nf-next 3/3] ipvs: add conn_lfactor and svc_lfactor sysctl vars, Florian Westphal <= Re: [PATCH nf-next 3/3] ipvs: add conn_lfactor and svc_lfactor sysctl vars, Julian Anastasov

Previous by Date:	[PATCH nf-next 3/3] ipvs: add conn_lfactor and svc_lfactor sysctl vars, Julian Anastasov
Next by Date:	[PATCH 0/2] ipvs: Fix incorrect use of HK_TYPE_KTHREAD housekeeping cpumask, Waiman Long
Previous by Thread:	[PATCH nf-next 3/3] ipvs: add conn_lfactor and svc_lfactor sysctl vars, Julian Anastasov
Next by Thread:	Re: [PATCH nf-next 3/3] ipvs: add conn_lfactor and svc_lfactor sysctl vars, Julian Anastasov
Indexes:	[Date] [Thread] [Top] [All Lists]