LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH nf-next 3/3] ipvs: add conn_lfactor and svc_lfactor sysctl va

To: Florian Westphal <fw@xxxxxxxxx>
Subject: Re: [PATCH nf-next 3/3] ipvs: add conn_lfactor and svc_lfactor sysctl vars
Cc: Simon Horman <horms@xxxxxxxxxxxx>, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, lvs-devel@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, Dust Li <dust.li@xxxxxxxxxxxxxxxxx>, Jiejian Wu <jiejian@xxxxxxxxxxxxxxxxx>
From: Julian Anastasov <ja@xxxxxx>
Date: Wed, 25 Mar 2026 06:54:42 +0200 (EET)
        Hello,

On Tue, 24 Mar 2026, Florian Westphal wrote:

> Julian Anastasov <ja@xxxxxx> wrote:
> > +                   *valp = val;
> > +                   if (rcu_dereference_protected(ipvs->conn_tab, 1))
> > +                           mod_delayed_work(system_unbound_wq,
> > +                                            &ipvs->conn_resize_work, 0);
> 
> Can I change this to rcu_access_pointer()?

        Yes, both proc handlers should use it, thanks!

> rcu_dereference_protected( ... , 1)
> 
> ... always looks like a bug to me, even though its fine here.

Regards

--
Julian Anastasov <ja@xxxxxx>



<Prev in Thread] Current Thread [Next in Thread>